From: Colin Walters <walters@verbum.org>
Date: Fri, 20 Nov 2009 01:15:46 +0000 (-0500)
Subject: Bump save timeout to 5 minutes, close output asynchronously
X-Git-Tag: archive/raspbian/50.5-1+rpi1~1^2~1013^2^2~10632
X-Git-Url: https://dgit.raspbian.org/%22http://www.example.com/cgi/%22/%22http:/www.example.com/cgi/%22?a=commitdiff_plain;h=e2ac769fd133d8d1ae830e572ff3b911358f05cf;p=gnome-shell.git

Bump save timeout to 5 minutes, close output asynchronously

The synchronous close causes us to block in fsync() which has extremely
poor interactivity implications on ext3.

Also, the 5 second timeout was an accidental commit from debugging, 5
minutes is fine.

https://bugzilla.gnome.org/show_bug.cgi?id=602456
---

diff --git a/src/shell-app-usage.c b/src/shell-app-usage.c
index c17c3d207..00a6c2ee5 100644
--- a/src/shell-app-usage.c
+++ b/src/shell-app-usage.c
@@ -65,7 +65,7 @@
  */
 
 /* How often we save internally app data, in seconds */
-#define SAVE_APPS_TIMEOUT_SECONDS 5    /* leave this low for testing, we can bump later if need be */
+#define SAVE_APPS_TIMEOUT_SECONDS (5 * 60)
 
 /* With this value, an app goes from bottom to top of the
  * usage list in 50 hours of use */
@@ -714,7 +714,7 @@ idle_save_application_usage (gpointer data)
 
 out:
   if (!error)
-    g_output_stream_close (G_OUTPUT_STREAM(data_output), NULL, &error);
+    g_output_stream_close_async (G_OUTPUT_STREAM (data_output), 0, NULL, NULL, NULL);
   g_object_unref (data_output);
   if (error)
     {